E2E test: Heartbeat handling — verify echo and callback#312
Closed
Conversation
Add comprehensive E2E tests to verify: - Heartbeat callback is invoked when server sends heartbeat - Connection remains alive after heartbeat exchange - No correlationId desync after heartbeat (regression test for #101) - Heartbeat without callback does not crash - Multiple heartbeats keep connection alive Tests use 1-second heartbeat interval and readLoop() to wait for server-initiated heartbeats, verifying the echo mechanism and callback system work correctly.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
Problem
StreamConnection::dispatchServerPush()handles heartbeats (key0x0017) by echoing back a heartbeat frame and optionally invoking a registered callback. No E2E test verifies this behavior. In production, heartbeat failures cause connection drops.Expected test
Why it matters
Notes
Acceptance criteria