E2E test: Connection resilience — operations after socket error#307
Merged
E2E test: Connection resilience — operations after socket error#307
Conversation
added 3 commits
March 30, 2026 14:37
- Remove unused $e variable in catch block (Rector) - Add previous exception to ConnectionException (Rector) - Fix socket type check in ConnectionResilienceTest (PHPStan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
Problem
No E2E test verifies client behavior when the underlying TCP socket encounters an error mid-session. In production, network partitions, server restarts, and load balancer timeouts cause socket errors.
Expected tests
Why it matters
readBytes()returnsnullonSOCKET_ETIMEDOUTbut throws on other errors — both paths need testingNotes
@group slowor@group destructiveAcceptance criteria
RuntimeExceptionon next operationisConnected()returnsfalseafter socket error