Skip to content

Fix #14703 False positive: buffer out of bounds, memcpy, array of pointer #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Fix #14703 False positive: buffer out of bounds, memcpy, array of pointer #8504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/symboldatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2503,7 +2503,12 @@ bool Variable::isMember() const {

bool Variable::isPointerArray() const
{
return isArray() && nameToken() && nameToken()->previous() && (nameToken()->strAt(-1) == "*");
if (!isArray())
return false;
const Token* tok = nameToken() ? nameToken()->previous() : nullptr;
while (Token::Match(tok, "const|volatile"))
tok = tok->previous();
return Token::simpleMatch(tok, "*");
}

bool Variable::isUnsigned() const
Expand Down
10 changes: 10 additions & 0 deletions test/testbufferoverrun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ class TestBufferOverrun : public TestFixture {
TEST_CASE(buffer_overrun_34); //#11035
TEST_CASE(buffer_overrun_35); //#2304
TEST_CASE(buffer_overrun_36);
TEST_CASE(buffer_overrun_37);
TEST_CASE(buffer_overrun_errorpath);
TEST_CASE(buffer_overrun_bailoutIfSwitch); // ticket #2378 : bailoutIfSwitch
TEST_CASE(buffer_overrun_function_array_argument);
Expand Down Expand Up @@ -3497,6 +3498,15 @@ class TestBufferOverrun : public TestFixture {
ASSERT_EQUALS("", errout_str());
}

void buffer_overrun_37() { // #14703
check("void f() {\n"
" const char *dst[256];\n"
" static const char * const src[] = {\"a\", \"b\", \"c\"};\n"
" memcpy(dst, src, sizeof(src));\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void buffer_overrun_errorpath() {
setMultiline();
Settings s = settings0;
Expand Down
Loading