Skip to content

Cef 109#324

Open
Schneegans wants to merge 10 commits into
mainfrom
feature/cef_109
Open

Cef 109#324
Schneegans wants to merge 10 commits into
mainfrom
feature/cef_109

Conversation

@Schneegans

Copy link
Copy Markdown
Member

No description provided.

@Schneegans Schneegans added this to the Version 1.8.0 milestone Jan 27, 2023
@coveralls

coveralls commented Feb 8, 2023

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4121807797

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 11 (0.0%) changed or added relevant lines in 6 files are covered.
  • 1348 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.1%) to 3.053%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-measurement-tools/src/FlagTool.cpp 0 1 0.0%
src/cs-gui/GuiItem.cpp 0 1 0.0%
src/cs-gui/internal/RequestHandler.cpp 0 1 0.0%
plugins/csp-timings/src/Plugin.cpp 0 2 0.0%
src/cs-core/GuiManager.cpp 0 2 0.0%
src/cs-gui/WebView.cpp 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
plugins/csp-measurement-tools/src/FlagTool.cpp 1 0.0%
src/cs-gui/internal/WebApp.cpp 1 38.46%
plugins/csp-lod-bodies/src/LodBody.cpp 5 0.0%
plugins/csp-atmospheres/src/AtmosphereRenderer.cpp 12 67.32%
plugins/csp-stars/src/Plugin.cpp 13 0.0%
src/cs-core/Settings.hpp 19 0.0%
src/cs-core/Settings.cpp 35 0.0%
plugins/csp-anchor-labels/src/AnchorLabel.cpp 39 0.0%
plugins/csp-timings/src/Plugin.cpp 43 0.0%
src/cs-core/GraphicsEngine.cpp 75 0.0%
Totals Coverage Status
Change from base Build 3854017668: 0.1%
Covered Lines: 515
Relevant Lines: 16869

💛 - Coveralls

@Schneegans Schneegans left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I added two small comments 😉

Comment thread make_externals.bat Outdated
Comment thread src/cs-gui/WebView.cpp Outdated
@Schneegans

Copy link
Copy Markdown
Member Author

Thanks again! However, as this requires at least CMake 3.19 and as there are some compilation issues if Doxygen is installed, we will put this on hold for a couple of months.

@Schneegans Schneegans removed this from the Version 1.8.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants