refactor: remove the need of maintaining rule exclusion for server crawler outside of the plugin#140
Merged
EsadCetiner merged 2 commits intocoreruleset:mainfrom Feb 25, 2026
Conversation
…awler outside of the plugin
theseion
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, false positives for the server crawler have to be resolved by copy-pasting an rule in the readme and kept in sync with any future plugin updates. This PR removes the need of maintaining a rule outside of the plugin which should simplify installation and maintenance for end users.
A new configuration variable has been created and if the IP address does not match the one configured in the SecRule, the variable will not be enabled and therefore will not enable the rule exclusions for the server crawler.
I haven't updated the readme to reflect this change (yet) to avoid confusing current users, I'll update it before a new plugin release which is when this change will be included.