-
-
Notifications
You must be signed in to change notification settings - Fork 323
Feature/ add a tag(--body-length-limit) for command commit #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
aa15fda
1f74bb2
faacc87
071e450
005b422
f514bdd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ | |
| import shutil | ||
| import subprocess | ||
| import tempfile | ||
| import textwrap | ||
| from itertools import chain | ||
| from typing import TYPE_CHECKING, TypedDict | ||
|
|
||
| import questionary | ||
|
|
@@ -37,6 +39,7 @@ class CommitArgs(TypedDict, total=False): | |
| edit: bool | ||
| extra_cli_args: str | ||
| message_length_limit: int | ||
| body_length_limit: int | ||
| no_retry: bool | ||
| signoff: bool | ||
| write_message_to_file: Path | None | ||
|
|
@@ -84,6 +87,7 @@ def _get_message_by_prompt_commit_questions(self) -> str: | |
|
|
||
| message = self.cz.message(answers) | ||
| self._validate_subject_length(message) | ||
| message = self._wrap_body(message) | ||
| return message | ||
|
|
||
| def _validate_subject_length(self, message: str) -> None: | ||
|
|
@@ -102,6 +106,28 @@ def _validate_subject_length(self, message: str) -> None: | |
| f"Length of commit message exceeds limit ({len(subject)}/{message_length_limit}), subject: '{subject}'" | ||
| ) | ||
|
|
||
| def _wrap_body(self, message: str) -> str: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a docstring explaining what this |
||
| """ | ||
| Wrap the body of the commit message to the specified length. | ||
| """ | ||
|
|
||
| body_length_limit = self.arguments.get( | ||
| "body_length_limit", self.config.settings["body_length_limit"] | ||
| ) | ||
| # By the contract, body_length_limit is set to 0 for no limit | ||
| if not body_length_limit or body_length_limit <= 0: | ||
| return message | ||
|
|
||
| lines = message.split("\n") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like |
||
| if len(lines) < 3: | ||
| return message | ||
|
|
||
| # First line is subject, second is blank line, rest is body | ||
|
Comment on lines
121
to
125
|
||
| wrapped_body_lines = [ | ||
| textwrap.wrap(line, width=body_length_limit) for line in lines[2:] | ||
| ] | ||
| return "\n".join(chain(lines[:2], chain.from_iterable(wrapped_body_lines))) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh I see. I thought Then the following is more semantically correct: |
||
|
|
||
| def manual_edit(self, message: str) -> str: | ||
| editor = git.get_core_editor() | ||
| if editor is None: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| feat: add feature | ||
|
|
||
| This is a very long line that exceeds 72 characters and should NOT be wrapped when body_length_limit is set to 0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| feat: add feature |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| feat: add feature | ||
|
|
||
| Line1 that is very long and exceeds the limit | ||
| Line2 that is very long and exceeds the limit | ||
| Line3 that is very long and exceeds the limit |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| feat: add feature | ||
|
|
||
| This is a very long line that exceeds 72 characters and should be | ||
| automatically wrapped by the system to fit within the limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can set a default value here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. What’s the difference between setting a default value here and using default_setting in defaults.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think
DEFAULT_SETTINGSis not a good design. I am not sure the mechanism of default value inargparse, not sure the exact difference here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally the default should be in DEFAULT_SETTINGS, which can be updated from the .cz.toml file. A default in argparse may override the setting in the file. You can add a test, to check that this is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that multiple default setting is undesirable. Should I remove the default setting for this tag from
cli.py?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after a second look, there should not be default values in cli.py because we want cz to use the settings from the configuration file if the value is None in arguments