fix(athena): outbound rpc stuck behind low prio queue timeout#38160
Open
stefpi wants to merge 4 commits into
Open
fix(athena): outbound rpc stuck behind low prio queue timeout#38160stefpi wants to merge 4 commits into
stefpi wants to merge 4 commits into
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
stefpi
changed the title
stefpi
force-pushed
the
athena-send-queue
branch
from
835d1b0 to
841d194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using 2 seperate high and low queues creates a hidden bug in
ws_send. When the high priority send queue is empty,ws_sendrunsdata = low_priority_send_queue.get(timeout=1). When low priority queue is also empty, a new message in the high priority queue doesn't cancel theget()because its a different queue, and we are forced to wait until the 1 second timeout expires before the high priority queue gets and sends its message in the websocket.We can fix this by using a
PriorityQueueinstead which will still properly send high priority messages first, but will also unblock instantly when there are no messages and a high priority message is added to the queue.