Skip to content

Upgrade rubocop to version 1.8.0#26

Closed
depfu[bot] wants to merge 1 commit intomasterfrom
depfu/update/rubocop-1.8.0
Closed

Upgrade rubocop to version 1.8.0#26
depfu[bot] wants to merge 1 commit intomasterfrom
depfu/update/rubocop-1.8.0

Conversation

@depfu
Copy link
Copy Markdown

@depfu depfu Bot commented Jan 8, 2021

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.76 → ~> 1.8) · Repo · Changelog

Release Notes

1.8.0

New features

Bug fixes

  • #9298: Fix an incorrect auto-correct for Lint/RedundantCopDisableDirective when there is a blank line before inline comment. (@koic)
  • #9233: Fix Style/SoleNestedConditional copying non-relevant comments during auto-correction. (@Darhazer)
  • #9312: Fix Layout/FirstHashElementLineBreak to apply to multi-line hashes with only a single element. (@muirdm)
  • #9316: Fix Style/EmptyLiteral registering wrong offense when using a numbered block for Hash.new, i.e. Hash.new { _1[_2] = [] }. (@agargiulo)
  • #9308: Fix an error for Layout/EmptyLineBetweenDefs when using endless class method. (@koic)
  • #9314: Fix an incorrect auto-correct for Style/RedundantReturn when multiple return values have a parenthesized return value. (@koic)
  • #9335: Fix an incorrect auto-correct for EnforcedStyle: require_parentheses of Style/MethodCallWithArgsParentheses with Style/NestedParenthesizedCalls. (@koic)
  • #9290: Fix a false positive for Layout/SpaceBeforeBrackets when using array literal method argument. (@koic)
  • #9333: Fix an error for Style/IfInsideElse when using a modifier if nested inside an else after elsif. (@koic)
  • #9303: Fix an incorrect auto-correct for Style/RaiseArgs with EnforcedStyle: compact when using exception instantiation argument. (@koic)

Changes

  • #9300: Make Lint/NonDeterministicRequireOrder not to register offense when using Ruby 3.0 or higher. (@koic)
  • #9320: Support unicode-display_width v2. (@dduugg)
  • #9288: Require Parser 3.0.0.0 or higher. (@koic)
  • #9337: Add AllowedIdentifiers to Naming/VariableName. (@dvandersluis)
  • #9295: Update Style/SingleLineMethods to correct to an endless method definition if they are allowed. (@dvandersluis)
  • #9331: Mark Style/MutableConstant as unsafe. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 38 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu Bot added the depfu label Jan 8, 2021
@depfu depfu Bot mentioned this pull request Jan 8, 2021
@depfu
Copy link
Copy Markdown
Author

depfu Bot commented Jan 12, 2021

Closed in favor of #27.

@depfu depfu Bot closed this Jan 12, 2021
@depfu depfu Bot deleted the depfu/update/rubocop-1.8.0 branch January 12, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants