Closed
Conversation
Author
|
Closed in favor of #17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.3) · Repo · Changelog
Release Notes
1.3.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 50 commits:
Cut 1.3Update ChangelogOnly report offenses as correctable if `Layout/LineLength` actually can correct them.[Fix #8978] Update `Layout/LineLength` autocorrection to be able to handle method calls with long argument lists.[Fix #9026] Update `Style/DocumentDynamicEvalDefinition` to detect comment blocks that document the evaluation.Fix formatting in CONTRIBUTING.md.[Fix #9011] Mark autocorrection for `Lint/Loop` as unsafe.Add new `Style/NilLambda` cop to check for lambdas that always return nil.[Fix #9025] Add `AllowedMethods` to `Lint/ConstantDefinitionInBlock`[Fix #9015] Update `Lint/EmptyBlock` to allow for empty lambdas.Merge pull request #9024 from koic/mark_unsafe_for_collection_compact[Fix #9023] Mark unsafe for `Style/CollectionCompact`.Add `NOTE` to keywords of `Style/CommentAnnotation`Support auto-correction for `Style/IfInsideElse`[Fix #9012] Allow `AllowedIdentifiers` to be specified for `Naming/VariableNumber`.Fix specs for SpaceInsideArrayLiteralBracketsMerge pull request #9009 from koic/update_rubocop_version_of_contributing_docMark `Style/InfiniteLoop` as unsafeUpdate RuboCop version of CONTRIBUTING.md when releasingAdd new `Style/StaticClass` cop[Fix #8761] Read `required_ruby_version` from gemspec file if it exists (#8885)Add new `Lint/EmptyClass` copFix an infinite loop when autocorrecting `Layout/TrailingWhitespace` + `Lint/LiteralInInterpolation`Re-enable spec after rubocop-rspec 2.0Remove exemptions for fixed copRemove obsolete gem `SafeYAML` compatibilityRefactor Lint/DuplicateCaseCondition cop with SetRemove dupes, thanks to `RSpec/RepeatedIncludeExample`Disable `RSpec/StubbedMock`.Remove pre < 1 configUpdate rubocop-rspec to 2.0move logic from `find_comma_pos` into `range_to_remove`move logic to new method to reduce Metrics/AbcSizemove logic from method `range_with_comma` to `range_to_remove`change `if` condition to single-line styleextract comma_pos logic to a method to reduce Metrics/AbcSize and Metrics/MethodLength[Fix #8118] fix autocorrect for redundant cop enable directiveMerge pull request #9000 from koic/use_cop_base_api_for_bundler_and_gemspec[Fix #8499] Fix Style/IfUnlessModifier to prevent offense when first-line comment and code after end blockUse `Cop::Base` API for some `Bundler` and `Gemspec` copsTweak some languageAdd new `Lint/DuplicateBranch` copMake Lint/Debugger configurable in terms of debugger methods (#8929)Improve the description of Style/IdenticalConditionalBranchesFix release notes[Fix #8996] Fix a false positive for `Style/MultipleComparison`[Fix #8998] Fix an error for `Style/NegatedIfElseCondition`Restore lost entries in the CHANGELOGTweak the funding languageSwitch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands