Closed
Conversation
Author
|
Closed in favor of #14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.0) · Repo · Changelog
Release Notes
1.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 36 commits:
Cut RuboCop 1.0!!!Move a changelog entryFix false positive in `Style/RedundantSelf` cop with nested `self` access (#8585)Merge pull request #8911 from koic/fix_an_error_when_occurring_cop_errorFix a false positive for `Layout/SpaceAroundOperators`Fix an error when ocurring cop errorMerge pull request #8908 from koic/add_extension_versions_when_using_verbose_versionShow extension cop versions when using `--verbose-version` optionAdd `on_after_<type>` callbacksFix an incorrect auto-correct for `Layout/ClassStructure`[Docs] Document the documentation license :-)[Docs] Add some additional documentation in preparation for RuboCop 1.0Handle redundant parentheses around an interpolated expression for `Style/RedundantParentheses` copMerge pull request #8905 from koic/remove_redundant_blank_for_to_json_messageRemove redundant blank for `Lint/ToJSON`'s offense message[Docs] Update versioning docs for 1.0Fix `VersionChanged` for `Security/Open`[Fix #8781] Change how comments are determined for `Style/SafeNavigation` autocorrection.[Fix #8901] Fix a false positive for `Naming/BinaryOperatorParameterName`Merge pull request #8894 from koic/fix_a_false_negative_for_security_openMake `Security/Open` aware of `URI.open`Default changed to disallow `Layout/TrailingWhitespace` in heredoc.Don't autocorrect static heredocs with trailing whitespacesFix `Layout/TrailingWhitespace` auto-correction in heredoc[Fix #8044] Change cop department name calculation[Fix #7944] Add `MaxUnannotatedPlaceholdersAllowed` option to `Style/FormatStringToken` cop.[Fix #7966] Enable all pending cops for RuboCop 1.0Update RuboCop/PerformanceUpdate RuboCop/RSpecCallback building was the single most time consuming method in all RuboCop, at around 8% of overall processing.Optimize `Cop#restrict_on_send`Avoid calling `extend` in `initialize`Remove unused methodTweak docFix an error for `Style/StringConcatenation` when correcting nested concatenable partsSwitch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands