feat: useYAt#82
Open
hannojg wants to merge 2 commits intocoinjar:masterfrom
Open
Conversation
Collaborator
|
Thanks so much for this pr :) I believe there's a conflict preventing it from being merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We might want to render any arbitrary view on the y-axis like the horizontal line. I thus created a
useYAthook so consumers can use that to build anything with it.I extracted the logic out of the
HorizontalLinecomponent, which now uses this hook.Test plan
I made sure that the horizontal line is still rendering as expected with that change.