Conversation
…tion - Provider: emit tool_calls only when finish_reason is present, clear after emit to prevent duplicates across multiple batches - Session: validate tool_call.arguments is valid JSON before execution, log error and skip if invalid - Add unit tests for provider tool call emission behavior - Add integration tests for tool calling with multiple providers
- Add extra_content field to ToolCall to store provider-specific data - Extract extra_content from OpenAI provider chunks (e.g., thought_signature) - Update ToolExecutor to preserve full ToolCall (including extra_content) - Add unit tests for extra_content preservation - Fix duplicate tool call emission (emit only on finish_reason) - Fix template test broken by sed command - Disable integration tests (consuming too many tokens)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let api_key = match env::var(api_key_env) { | ||
| Ok(key) => key, | ||
| Err(_) => { | ||
| eprintln!( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.