perf: sliding refactoring, second take#32
Merged
Conversation
Owner
|
I will merge this once I have completed this: #33 That way in the future I can know without locally running if tests are failing and prevent merging PRs that have failing tests. |
codereport
requested changes
Apr 16, 2025
Owner
codereport
left a comment
codereport
left a comment
There was a problem hiding this comment.
Can you fix merge conflict?
codereport
requested changes
Apr 17, 2025
Owner
codereport
left a comment
codereport
left a comment
There was a problem hiding this comment.
nice! Tests are working with CI now, once remove merge conflict I will merge (I think just revert ci.yml changes
aparatext
force-pushed
the
master
branch
3 times, most recently
from
9abc3c0 to
cb78d55
Compare
aparatext
changed the title
sliding refactoring: second takesliding refactoring, second take
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day. I apologize for taking so long to circle back on this — life'd been getting in the way as of late.
This is a follow-up to #31. I've fixed all the failing tests, and it looks like my changes are now ready to be merged. The commits are a bit messy, so consider squashing them.
Let me know if you have any questions or feedback, and thanks again for reviewing.