fix(explain): repaint the original panel during strip drag/reset#16
Merged
Conversation
The drag and reset handlers scheduled only log/bend/exp, but the original panel also consumes panU/panV, so it stayed frozen during a drag and then snapped to the accumulated pan on the next full re-render (source switch or resize). Add 'orig' to both schedule() calls so it follows the others live, matching its stated intent. Fixes #15 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the cosmetic desync flagged in the pre-merge review of #13: on
/explain, dragging the flat strip moved the log / bend / exp panels but left the original frozen, which then snapped to the accumulated pan on the next full re-render (source switch or resize).The
origpanel already consumespanU/panV(src/explain/main.ts:215, comment "zoomed/turned by the pan"), but the drag (:412) and reset (:429) handlers scheduled only['log','bend','exp']. This adds'orig'to bothschedule()calls so it follows the others live — restoring the explainer's "drag one, all follow" contract.Change
Two lines:
schedule(['log','bend','exp'])→schedule(['orig','log','bend','exp'])in the drag and reset handlers. No change to the other panels or any other code path.Test plan
npm run check— 0 errors / 0 warningsnpm test— 44/44npm run build— clean (only theexplainbundle hash changes;mainuntouched)Closes #15
🤖 Generated with Claude Code