Open
Conversation
95076d0 to
437c15b
Compare
437c15b to
270fa50
Compare
270fa50 to
6a2a0eb
Compare
|
This pull request addresses two issues by fixing a command injection vulnerability in main.py through user input sanitization with shlex.quote() and enhancing security in html.js by encoding the kitId with encodeURIComponent() to prevent cross-site scripting attacks. Other changes in html.js are related to formatting and do not affect functionality.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 2 issues.
Fixed command injection vulnerability
The diff shows that a security vulnerability, specifically a command injection vulnerability, has been fixed. The user input is now being sanitized using the shlex.quote() function before being used in a command. This prevents malicious user input from being executed as part of the command.Refactoring and improving security of script loading
The diff shows that the script loading code has been refactored for better readability and security. The changes include the addition of encodeURIComponent() function to the kitId when forming the script source URL, which can prevent potential cross-site scripting (XSS) attacks by ensuring the kitId is properly encoded. The rest of the changes are mainly formatting and do not alter the functionality of the code.