fix(worker): Exclude shelter paths from archive service operations

[sentry]

Fixes WORKER-Y85. The issue was that: Minio client misconfigured, sending S3-formatted requests for codecov-production bucket to Google Cloud Storage, resulting in InternalError.

• Modified the condition for deleting archive files to prevent deletion of files with URLs starting with "shelter/".
• Added a check to prevent rewriting archive files if their URL starts with "shelter/".
• Ensures that files managed by the Shelter service are not inadvertently processed by the archive service in the worker.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13423687

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

---

Note

Low Risk
Small conditional change that only narrows when archive storage operations run; low risk aside from potentially leaving some shelter/ artifacts untouched if expectations were different.

Overview
Prevents the worker from calling ArchiveService.delete_file or ArchiveService.write_file for uploads whose archive_url starts with shelter/, while keeping existing behavior for other non-HTTP archive paths.

This avoids rewriting or deleting Shelter-managed objects during upload processing (notably for v1 report rewrite and delete-on-success flows).

^{Reviewed by Cursor Bugbot for commit 029d48a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 029d48a. Configure here.}

[cursor]

Shelter path fix missing from parallel rewrite_or_delete_upload function

Medium Severity

The shelter-path exclusion was only added to rewrite_or_delete_upload in processing.py, but an analogous rewrite_or_delete_upload function in ta_processor.py performs the same delete_file and write_file operations on archive URLs without any shelter-path guard. If the test analytics code path encounters a shelter URL, it will still send the misconfigured S3 request to GCS, reproducing the exact bug this PR aims to fix.

 

^{Reviewed by Cursor Bugbot for commit 029d48a. Configure here.}

[codecov-notifications]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/worker/services/processing/processing.py	33.33%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[sentry]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (029d48a).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/worker/services/processing/processing.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1307     1307              
  Lines       48017    48018       +1     
  Branches     1636     1636              
==========================================
  Hits        44299    44299              
- Misses       3407     3408       +1     
  Partials      311      311              

Flag	Coverage Δ
workerintegration	58.54% <33.33%> (-0.01%)	⬇️
workerunit	90.38% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.