Skip to content

fix(worker): Skip archive writing for Shelter paths#835

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/skip-shelter-archive-write
Open

fix(worker): Skip archive writing for Shelter paths#835
sentry[bot] wants to merge 1 commit intomainfrom
seer/fix/skip-shelter-archive-write

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 16, 2026

Fixes WORKER-Y84. The issue was that: Rewriting processed V1 Shelter reports to GCS fails due to invalid :::: characters in the object path.

  • Added a conditional check to prevent archive_service.write_file from being called for archive_urls that begin with "shelter/".
  • This change addresses issues where Shelter paths, managed externally, may contain characters invalid for GCS/MinIO write operations.
  • Ensures that only non-Shelter related version 1 reports are rewritten to the archive service.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13423680

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Small conditional change in worker archive rewrite logic; risk is limited to potentially not rewriting some V1 reports if the shelter/ prefix check is incorrect.

Overview
Prevents the worker from rewriting processed V1 reports back to the archive when archive_url starts with shelter/, avoiding GCS/MinIO write failures caused by invalid characters in externally-managed Shelter object paths.

Non-Shelter V1 reports continue to be rewritten as before, and delete-archive behavior is unchanged.

Reviewed by Cursor Bugbot for commit 5341a02. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (5341a02).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/processing/processing.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1307     1307              
  Lines       48017    48018       +1     
  Branches     1636     1636              
==========================================
  Hits        44299    44299              
- Misses       3407     3408       +1     
  Partials      311      311              
Flag Coverage Δ
workerintegration 58.54% <0.00%> (-0.01%) ⬇️
workerunit 90.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/processing/processing.py 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants