fix(worker): Skip archive writing for Shelter paths#835
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
fix(worker): Skip archive writing for Shelter paths#835sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 1307 1307
Lines 48017 48018 +1
Branches 1636 1636
==========================================
Hits 44299 44299
- Misses 3407 3408 +1
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y84. The issue was that: Rewriting processed V1 Shelter reports to GCS fails due to invalid
::::characters in the object path.archive_service.write_filefrom being called forarchive_urls that begin with "shelter/".This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13423680
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Small conditional change in worker archive rewrite logic; risk is limited to potentially not rewriting some V1 reports if the
shelter/prefix check is incorrect.Overview
Prevents the worker from rewriting processed V1 reports back to the archive when
archive_urlstarts withshelter/, avoiding GCS/MinIO write failures caused by invalid characters in externally-managed Shelter object paths.Non-Shelter V1 reports continue to be rewritten as before, and delete-archive behavior is unchanged.
Reviewed by Cursor Bugbot for commit 5341a02. Bugbot is set up for automated code reviews on this repo. Configure here.