Skip to content

perf(worker): Optimize test analytics flake processing DB queries#827

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-flake-db-optimization
Open

perf(worker): Optimize test analytics flake processing DB queries#827
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-flake-db-optimization

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 15, 2026

Fixes WORKER-Y7W. The issue was that: Iterating through uploads and fetching testruns individually for each upload causes N+1 queries to the ta_timeseries database.

  • Refactored get_testruns to fetch testruns for multiple uploads in a single database query.
  • Modified process_single_upload to accept pre-fetched testruns, eliminating per-upload database calls.
  • Updated process_flakes_for_commit to batch fetch and group testruns by upload, significantly reducing database query count.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13355253

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance refactor that changes how Testrun rows are fetched and grouped; main risk is subtle behavioral differences if upload ordering/empty-upload cases are mishandled.

Overview
Optimizes flake processing to avoid N+1 DB queries. get_testruns now accepts multiple upload_ids and process_flakes_for_commit prefetches all recent Testruns in a single query, groups them by upload_id, and passes those lists into process_single_upload.

process_single_upload no longer queries per upload and instead operates on the provided pre-fetched testruns, keeping the existing outcome updates via bulk_update.

Reviewed by Cursor Bugbot for commit 7fd3d25. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (9eed0bb) to head (7fd3d25).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48012    48016    +4     
  Branches     1636     1636           
=======================================
+ Hits        44294    44298    +4     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.53% <22.22%> (-0.01%) ⬇️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants