perf(worker): Optimize commit loading in comparison task#825
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
perf(worker): Optimize commit loading in comparison task#825sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1306 1306
Lines 48013 48013
Branches 1636 1636
=======================================
Hits 44295 44295
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y7T. The issue was that: CompareCommit fetching lacks eager loading of
_report_json, causing N+1 database queries when accessing commit reports.load_onlyforCommitattributes when eagerly loadingcompare_commitandbase_commit.Commitobjects in thecompute_comparisontask.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13351436
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Medium risk because it changes SQLAlchemy eager-loading and column selection for
Commitobjects; missing a required field could surface as runtime errors or unexpected lazy loads during comparison computation.Overview
Speeds up the
compute_comparisonworker task by refining theCompareCommitfetch to eager-loadcompare_commitandbase_commitwithload_only, including_report_jsonand storage-path fields, while still joining the needed repository relations.This reduces unnecessary columns and avoids N+1 queries when accessing commit report data during comparison computation.
Reviewed by Cursor Bugbot for commit 1f7a005. Bugbot is set up for automated code reviews on this repo. Configure here.