Skip to content

perf(worker): Optimize commit loading in comparison task#825

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/optimize-comparison-commit-loading
Open

perf(worker): Optimize commit loading in comparison task#825
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/optimize-comparison-commit-loading

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 15, 2026

Fixes WORKER-Y7T. The issue was that: CompareCommit fetching lacks eager loading of _report_json, causing N+1 database queries when accessing commit reports.

  • Implemented load_only for Commit attributes when eagerly loading compare_commit and base_commit.
  • Reduces the number of columns fetched from the database for Commit objects in the compute_comparison task.
  • Improves database query performance by retrieving only essential commit data.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13351436

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Medium risk because it changes SQLAlchemy eager-loading and column selection for Commit objects; missing a required field could surface as runtime errors or unexpected lazy loads during comparison computation.

Overview
Speeds up the compute_comparison worker task by refining the CompareCommit fetch to eager-load compare_commit and base_commit with load_only, including _report_json and storage-path fields, while still joining the needed repository relations.

This reduces unnecessary columns and avoids N+1 queries when accessing commit report data during comparison computation.

Reviewed by Cursor Bugbot for commit 1f7a005. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (43f5168) to head (1f7a005).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48013    48013           
  Branches     1636     1636           
=======================================
  Hits        44295    44295           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.55% <100.00%> (ø)
workerunit 90.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants