perf(worker): Cache flag reports and optimize comparison totals#822
Draft
sentry[bot] wants to merge 3 commits intomainfrom
Draft
perf(worker): Cache flag reports and optimize comparison totals#822sentry[bot] wants to merge 3 commits intomainfrom
sentry[bot] wants to merge 3 commits intomainfrom
Conversation
thomasrockhu-codecov
approved these changes
Apr 15, 2026
Fixes CI Run Lint (ruff format) on PR branch. Made-with: Cursor
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1306 1306
Lines 48013 48017 +4
Branches 1636 1637 +1
=======================================
+ Hits 44295 44299 +4
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Assert Flag.report filter uses paths=None (matches implementation). - Add regression test that filtered report is reused across accesses. - Add unit tests for ComputeComparisonTask.get_flag_comparison_totals. Raises Codecov patch coverage for PR changes. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-PFZ. The issue was that: Flag.totals property creates new filtered reports, triggering repeated database queries for each flag in a loop.
Flag.reportproperty to avoid redundant filtering operations.compute_comparison_for_commit_and_pullto pre-fetchbase_report_flagsanddiffonce before iterating through flags.get_flag_comparison_totalsto accept pre-fetchedhead_report_flags,base_report_flags, anddiffas arguments, reducing repeated calls and lookups.This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 13349039
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.