Skip to content

perf(worker): Batch fetch testruns for flake processing#817

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-fetch-testruns-flakes
Open

perf(worker): Batch fetch testruns for flake processing#817
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-fetch-testruns-flakes

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 15, 2026

Fixes WORKER-Y7N. The issue was that: Testruns are fetched individually for each upload within a loop, causing an N+1 query pattern.

  • Refactored get_testruns into get_testruns_for_uploads to accept multiple upload IDs and return a dictionary of testruns grouped by upload ID.
  • Modified process_single_upload to directly accept a list of testruns, removing its internal fetching logic.
  • Updated process_flakes_for_commit to fetch all relevant testruns for all uploads in a single batched query.
  • Significantly reduced database queries from N+1 to 2 when processing flakes for multiple uploads, improving performance.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13332217

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance refactor that reduces DB queries by batching Testrun fetches; main risk is subtle behavior differences in how testruns are grouped per upload and bulk-updated.

Overview
Reduces an N+1 query pattern in flake processing by fetching all recent Testruns for a commit’s uploads in a single query and grouping them by upload_id.

process_single_upload is refactored to accept a pre-fetched list of testruns (instead of querying per upload), and process_flakes_for_commit now batches upload retrieval and passes the grouped testruns through before bulk-updating outcomes.

Reviewed by Cursor Bugbot for commit 27cf839. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (27cf839).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48004    48010    +6     
  Branches     1636     1636           
=======================================
+ Hits        44286    44292    +6     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.56% <16.66%> (-0.02%) ⬇️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants