perf(worker): Batch testrun fetching for flake processing#816
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
perf(worker): Batch testrun fetching for flake processing#816sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 1306 1306
Lines 48004 47999 -5
Branches 1636 1636
==========================================
- Hits 44286 44281 -5
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y7M. The issue was that: Looping through uploads causes N+1 queries to fetch and update testruns in the ta_timeseries database.
process_flakes_for_committo fetch all relevant testruns for a commit's uploads in a single query.get_testrunsto accept a list of upload IDs, enabling batch fetching.process_single_uploadhelper function, integrating its logic directly intoprocess_flakes_for_commit.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13327093
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Primarily a performance refactor that changes query shape (single
upload_id__infetch + bulk update) but keeps the same outcome-handling logic; risk is limited to potential edge cases whenupload_idsis empty or large.Overview
Batches flake processing per commit to avoid N+1 DB queries.
process_flakes_for_commitnow fetches all relevant uploads up front, then pulls all recentTestruns for thoseupload_idsin a single query and performs onebulk_update.Removes the per-upload
process_single_uploadhelper and updatesget_testrunsto accept a list of upload IDs, while preserving the existing pass/fail handling andflaky_failoutcome normalization.Reviewed by Cursor Bugbot for commit a4bfec0. Bugbot is set up for automated code reviews on this repo. Configure here.