Skip to content

perf(worker): Batch testrun fetching for flake processing#816

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-testruns-ilFUK7
Open

perf(worker): Batch testrun fetching for flake processing#816
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-testruns-ilFUK7

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 15, 2026

Fixes WORKER-Y7M. The issue was that: Looping through uploads causes N+1 queries to fetch and update testruns in the ta_timeseries database.

  • Refactored process_flakes_for_commit to fetch all relevant testruns for a commit's uploads in a single query.
  • Updated get_testruns to accept a list of upload IDs, enabling batch fetching.
  • Removed the process_single_upload helper function, integrating its logic directly into process_flakes_for_commit.
  • Reduced the number of database queries during flake processing, improving efficiency.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13327093

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Primarily a performance refactor that changes query shape (single upload_id__in fetch + bulk update) but keeps the same outcome-handling logic; risk is limited to potential edge cases when upload_ids is empty or large.

Overview
Batches flake processing per commit to avoid N+1 DB queries. process_flakes_for_commit now fetches all relevant uploads up front, then pulls all recent Testruns for those upload_ids in a single query and performs one bulk_update.

Removes the per-upload process_single_upload helper and updates get_testruns to accept a list of upload IDs, while preserving the existing pass/fail handling and flaky_fail outcome normalization.

Reviewed by Cursor Bugbot for commit a4bfec0. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (a4bfec0).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1306     1306              
  Lines       48004    47999       -5     
  Branches     1636     1636              
==========================================
- Hits        44286    44281       -5     
  Misses       3407     3407              
  Partials      311      311              
Flag Coverage Δ
workerintegration 58.58% <6.25%> (+<0.01%) ⬆️
workerunit 90.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants