Skip to content

perf(worker): Eagerly load related objects for flake processing#814

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-flake-eager-load
Open

perf(worker): Eagerly load related objects for flake processing#814
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/ta-flake-eager-load

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 15, 2026

Fixes WORKER-Y7J. The issue was that: get_relevant_uploads lacks select_related for ReportSession's foreign keys, causing N+1 queries when iterating uploads.

  • Adds select_related to the TestInstance query in ta_process_flakes.py.
  • Eagerly loads report, report__commit, report__commit__repository, and report__commit__repository__author.
  • Optimizes database queries by preventing N+1 issues when accessing related objects during flake processing.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13317433

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance-only change that adjusts a queryset to eager-load related ReportSession foreign keys; main risk is unexpected query shape/memory increase on very large result sets.

Overview
Reduces N+1 database queries during flake processing by updating get_relevant_uploads in ta_process_flakes.py to select_related the ReportSession's report -> commit -> repository -> author chain when fetching uploads for a commit.

Reviewed by Cursor Bugbot for commit 1e7828c. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (1e7828c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48004    48004           
  Branches     1636     1636           
=======================================
  Hits        44286    44286           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.58% <ø> (ø)
workerunit 90.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants