Fix Sentry context ordering and add missing MERGED upload state case#3974
Fix Sentry context ordering and add missing MERGED upload state case#3974cursor[bot] wants to merge 2 commits intomainfrom
Conversation
- Move setContext call before captureException to ensure zod validation context is attached to Sentry events - Add case for merged state in humanReadableOverview to prevent undefined in uploads overview
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cy/add_merged_upload_state #3974 +/- ##
==============================================================
- Coverage 98.56% 98.54% -0.02%
==============================================================
Files 826 826
Lines 15221 15223 +2
Branches 4459 4460 +1
==============================================================
Hits 15002 15002
- Misses 212 214 +2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cy/add_merged_upload_state #3974 +/- ##
==============================================================
- Coverage 98.56% 98.54% -0.02%
==============================================================
Files 826 826
Lines 15221 15223 +2
Branches 4451 4460 +9
==============================================================
Hits 15002 15002
- Misses 212 214 +2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
- Coverage 98.58% 98.54% -0.04%
==========================================
Files 826 826
Lines 15214 15223 +9
Branches 4447 4460 +13
==========================================
+ Hits 14999 15002 +3
- Misses 208 214 +6
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
- Coverage 98.58% 98.54% -0.04%
==========================================
Files 826 826
Lines 15214 15223 +9
Branches 4455 4452 -3
==========================================
+ Hits 14999 15002 +3
- Misses 208 214 +6
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 60 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
|
|
Automatically closed this PR because it was created by Bugbot autofix for #3973, and that PR was closed. |
Description
This PR fixes two bugs found during code review:
Sentry context ordering: Fixed the order of operations in
rejectNetworkError.tsto ensure thatsetContextis called beforecaptureException. This ensures that zod validation context (issues and error messages) is properly attached to Sentry events for parsing errors.Missing MERGED state case: Added a case for the
mergedstate in thehumanReadableOverviewfunction inextractUploads.ts. Without this case, uploads with the MERGED state would show as "undefined" in the uploads overview string.Notable Changes
scope.setContext('zod_validation', ...)call beforescope.captureException(err)insrc/shared/api/rejectNetworkError.tsUploadStateEnum.mergedreturning'merged'inhumanReadableOverviewfunction insrc/shared/utils/extractUploads.ts