Open
Conversation
flowln
reviewed
Mar 9, 2026
Contributor
flowln
left a comment
flowln
left a comment
There was a problem hiding this comment.
My only other notes are that these two commits should be a single one, and I think it may be worth to add one or two tests for this plan, seems to be pretty straightforward.
RafaelLyra8
force-pushed
the
scan_with_delay
branch
from
84b1b74 to
7538aeb
Compare
flowln
reviewed
Mar 24, 2026
Comment on lines
+64
to
+65
| yield from per_step(detectors, step, pos_cache) | ||
| yield from sleep(delay) |
Contributor
There was a problem hiding this comment.
This will always cause the sleep to occur after the trigger_and_read (or similar). There really does not seem to be a good way of making custom per_steps work in all cases in this plan. I'd remove that possibility altogether, and direct users to use a simple scan plan if that's what they need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.