Add more customization options#8
Open
amake wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
I don't mean to prod, but do you have a timeline on which you might be able to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following parts of the VLDocking interface are currently impossible or cumbersome to customize:
AutoHideButtonbackground color:setOpacity()is currently used (and from outside the UI class) to change the appearance, which precludes color customization.DockViewTitleBargradient: Currently impossible to disable without completely reimplementing the UI class.AutoHideButtonPanelbackground color: Only settable by overriding the UI class.This patch allows the above to be customized via the following
UIManagerkeys:AutoHideButton.background(Color)DockViewTitleBar.disableCustomPaint(Boolean)AutoHideButtonPanel.background(Color)When these are not specified (
null) the behavior is identical to before.I'm not sure where the new keys should be documented. Please let me know.