This repository was archived by the owner on Oct 29, 2021. It is now read-only.
Rails integration#2
Open
EnriqueVidal wants to merge 2 commits intomasterfrom
Open
Conversation
There was a problem hiding this comment.
I think we should do the Array#shuffle method. All sorts of cleverness going on here, shuffle 3 times, random location, then reverse the deck lol
Member
Author
There was a problem hiding this comment.
Right, the same feeling I have, but when I re-factored I decided to test first to better understand what the original developer was trying to accomplish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will refactor the whole gem to be a Rails compatible texas holdem' gem, it is not finished yet but this you can see the incremental improvements in here.