feat: add vendor symlink in WEBDIR for Composer autoload compatibility#1227
Merged
feat: add vendor symlink in WEBDIR for Composer autoload compatibility#1227
Conversation
Create a symlink from WEBDIR/vendor to the actual vendor directory during
Composer compilation. This allows apps to use relative require paths like
`require 'vendor/autoload.php'` from their web root (e.g., htdocs).
The symlink is only created when:
- WEBDIR exists (e.g., htdocs directory)
- Vendor directory is not already inside WEBDIR
- No existing vendor directory or symlink exists in WEBDIR
- Actual vendor directory exists after Composer installation
Example: If composer.json specifies vendor-dir as "lib/vendor" and WEBDIR is
"htdocs", this creates htdocs/vendor -> ../lib/vendor
This maintains backward compatibility for apps that reference vendor/autoload.php
from their web-accessible directory while keeping the actual vendor directory
outside the web root for security.
Also fixes placeholder syntax: #{LIBDIR} -> @{LIBDIR} to match the unified
@{VAR} syntax used throughout the buildpack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a
htdocs/vendor -> ../lib/vendorsymlink during Composer installation so apps can referencevendor/autoload.phpfrom their web root while keeping the actual vendor directory outside the web root for security.Problem
Apps using a custom
vendor-dir(e.g.lib/vendor) and referencingrequire 'vendor/autoload.php'from the web root (e.g.htdocs/) would fail because thevendordirectory is not accessible relative tohtdocs.Solution
After Composer installation, create a symlink
WEBDIR/vendor -> ../lib/vendorwhen:WEBDIRexists (e.g.htdocsdirectory)WEBDIRvendordirectory or symlink inWEBDIRChanges
src/php/extensions/composer/composer.go— add symlink creation logic after install#{LIBDIR}→@{LIBDIR}to match unified@{VAR}syntaxTesting
Existing Composer integration tests continue to pass.