Introduce a cidr list to exclude from connection rate limiting#883
Draft
b1tamara wants to merge 1 commit intocloudfoundry:masterfrom
Draft
Introduce a cidr list to exclude from connection rate limiting#883b1tamara wants to merge 1 commit intocloudfoundry:masterfrom
b1tamara wants to merge 1 commit intocloudfoundry:masterfrom
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Soha-Albaghdady
requested changes
Feb 27, 2026
| @@ -0,0 +1,25 @@ | |||
| # generated from cidrs_to_exclude_from_blocking.txt.erb | |||
Contributor
There was a problem hiding this comment.
I suggest to rename the file to cidrs_to_exclude_from_rate_limiting.txt to show that it is connected to rate limiting.
| it 'adds http-request deny condition to http-in and https-in frontends' do | ||
| expect(frontend_http).to include('tcp-request connection reject if { sc_conn_rate(0) gt 5 }') | ||
| it 'adds tcp-request connection reject condition to http-in and https-in frontends' do | ||
| expect(frontend_http).to include('tcp-request connection reject if { sc_conn_rate(0) gt 5 } !cidr_list_to_exclude') |
Contributor
There was a problem hiding this comment.
The acl check is missing here as the acl will exist but the file will be empty
expect(frontend_http).to include('acl cidr_list_to_exclude src -f /var/vcap/jobs/haproxy/config/cidrs_to_exclude_from_blocking.txt')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.