Replace loggregator_emitter gem with gRPC V2 client#5043
Draft
serdarozerr wants to merge 2 commits intocloudfoundry:mainfrom
Draft
Replace loggregator_emitter gem with gRPC V2 client#5043serdarozerr wants to merge 2 commits intocloudfoundry:mainfrom
serdarozerr wants to merge 2 commits intocloudfoundry:mainfrom
Conversation
feat: replace loggregator V1 UDP emitter with gRPC V2 client Remove the loggregator_emitter gem (V1, UDP/beefcake) and replace it with a new LoggregatorEmitter::Client backed by gRPC V2. The client uses lazy stub initialization to avoid gRPC background threads conflicting with Puma's thread pool at startup. Config keys renamed from `router`/`internal_url` to `endpoint`, with optional mTLS cert fields added to all three schemas (api, clock, worker). Integration and unit tests updated to use the V2 gRPC fake server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the deprecated
loggregator_emittergem (V1, UDP/beefcake protobuf) with a newLoggregatorEmitter::Clientbuilt on gRPC V2. The loggregator config keyrouteris renamed toendpointandinternal_urlis removed. Optional mTLS cert fields (ca_file,cert_file,key_file) are added to the api, clock, and worker schemas. The gRPC stub is initialized lazily on the first emit call to avoid conflicts with Puma's thread pool at startup.Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests