ci: add Semgrep OSS scanning workflow#6651
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR migrates the Semgrep workflow from Pro (container-based, token-auth) to Community Edition (pip-installed, --config=auto).
Issues
-
ubuntu-slimis not a standard GitHub-hosted runner label — GitHub providesubuntu-latest,ubuntu-24.04,ubuntu-22.04, etc.ubuntu-slimwill cause the job to hang waiting for a runner that never arrives (unless this org has a self-hosted runner with that label, in which case ignore this). Every other workflow in this repo usesubuntu-latest,ubuntu-24.04, orubuntu-22.04. -
actions/checkout@v5— this repo has standardised on@v6— every other workflow (except one legacy one at@v4) usesactions/checkout@v6. Using@v5here is inconsistent and misses any fixes/improvements in v6.
| container: | ||
| image: semgrep/semgrep | ||
| name: semgrep-oss | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
ubuntu-slim is not a standard GitHub-hosted runner label. This will cause the job to queue indefinitely unless the org has a self-hosted runner with that exact label. The rest of this repo uses ubuntu-latest or versioned labels.
| runs-on: ubuntu-slim | |
| runs-on: ubuntu-latest |
|
|
||
|
|
||
|
|
||
| - uses: actions/checkout@v5 |
There was a problem hiding this comment.
This repo has standardised on actions/checkout@v6 — every other workflow already uses v6.
| - uses: actions/checkout@v5 | |
| - uses: actions/checkout@v6 |
|
Review posted successfully on PR #6651 with two findings:
Both issues have concrete |
Merging this PR will not alter performance
Comparing Footnotes
|
Summary
Adds Semgrep Community Edition (OSS) scanning to this repository as part of the App&ProdSec team's migration from Semgrep Pro to Semgrep CE.
What it does
pushto the main/master branch, and monthly on a staggered schedule.actions/cache@v5sopip install semgreponly runs on cold cache (first run, version bump, or 7-day idle).semgrep==1.160.0with--config=auto(default OSS ruleset).ubuntu-slimwithcontents: readtoken scope.For reviewers
See the internal App&ProdSec email for migration context, or ping us internally.