Skip to content

Refactor diff handling#1772

Open
prymitive wants to merge 1 commit intomainfrom
git
Open

Refactor diff handling#1772
prymitive wants to merge 1 commit intomainfrom
git

Conversation

@prymitive
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.80.0-1-g227d0294
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.77301% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.43%. Comparing base (8f7fe5a) to head (227d029).

Files with missing lines Patch % Lines
internal/discovery/glob.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
- Coverage   99.44%   99.43%   -0.01%     
==========================================
  Files         113      113              
  Lines       13752    13635     -117     
==========================================
- Hits        13675    13558     -117     
  Misses         42       42              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt   │               new.txt               │
                    │   sec/op    │   sec/op     vs base                │
GlobFinder-4          19.78m ± 3%   22.07m ± 3%  +11.57% (p=0.000 n=10)
GitFinder-4           373.0m ± 2%   376.5m ± 1%        ~ (p=0.353 n=10)
CheckRules-4           9.625 ± 1%    9.644 ± 1%        ~ (p=0.529 n=10)
RuleIsIdentical-4     5.294m ± 2%   5.312m ± 3%        ~ (p=0.436 n=10)
GetChecksForEntry-4   117.6m ± 2%   118.4m ± 1%        ~ (p=0.063 n=10)
geomean               134.6m        138.2m        +2.66%

                    │    old.txt     │                new.txt                │
                    │      B/op      │     B/op      vs base                 │
GlobFinder-4          7.151Mi ± 0%     7.748Mi ± 0%  +8.35% (p=0.000 n=10)
GitFinder-4           16.10Mi ± 1%     16.85Mi ± 1%  +4.63% (p=0.000 n=10)
CheckRules-4          888.7Mi ± 0%     888.0Mi ± 0%       ~ (p=0.353 n=10)
RuleIsIdentical-4       0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   56.84Mi ± 0%     56.84Mi ± 0%       ~ (p=0.448 n=10)
geomean                            ²                 +2.52%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    old.txt    │               new.txt                │
                    │   allocs/op   │  allocs/op   vs base                 │
GlobFinder-4          111.1k ± 0%     112.9k ± 0%  +1.63% (p=0.000 n=10)
GitFinder-4           148.8k ± 0%     149.9k ± 0%  +0.79% (p=0.000 n=10)
CheckRules-4          9.708M ± 0%     9.706M ± 0%       ~ (p=0.165 n=10)
RuleIsIdentical-4      0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   927.9k ± 0%     927.9k ± 0%       ~ (p=0.506 n=10)
geomean                           ²                +0.48%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt   │            new.txt            │
        │   sec/op    │   sec/op     vs base          │
Parse-4   17.22m ± 2%   17.22m ± 2%  ~ (p=0.684 n=10)

        │   old.txt    │            new.txt             │
        │     B/op     │     B/op      vs base          │
Parse-4   6.324Mi ± 0%   6.324Mi ± 0%  ~ (p=0.698 n=10)

        │   old.txt   │             new.txt             │
        │  allocs/op  │  allocs/op   vs base            │
Parse-4   102.8k ± 0%   102.8k ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt   │              new.txt               │
               │   sec/op    │   sec/op     vs base               │
LabelsSource-4   7.661m ± 3%   7.482m ± 2%  -2.34% (p=0.019 n=10)

               │   old.txt    │            new.txt             │
               │     B/op     │     B/op      vs base          │
LabelsSource-4   5.698Mi ± 0%   5.700Mi ± 0%  ~ (p=0.353 n=10)

               │   old.txt   │            new.txt            │
               │  allocs/op  │  allocs/op   vs base          │
LabelsSource-4   46.76k ± 0%   46.76k ± 0%  ~ (p=0.207 n=10)

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt   │            new.txt            │
                    │   sec/op    │   sec/op     vs base          │
QueryCacheOnlySet-4   105.2n ± 1%   105.2n ± 1%  ~ (p=0.590 n=10)

                    │  old.txt   │            new.txt             │
                    │    B/op    │    B/op     vs base            │
QueryCacheOnlySet-4   64.00 ± 0%   64.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                    │  old.txt   │            new.txt             │
                    │ allocs/op  │ allocs/op   vs base            │
QueryCacheOnlySet-4   1.000 ± 0%   1.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants