Declare React as an optional peer dependency of partysocket#340
Merged
threepointone merged 1 commit intomainfrom Feb 22, 2026
Merged
Declare React as an optional peer dependency of partysocket#340threepointone merged 1 commit intomainfrom
threepointone merged 1 commit intomainfrom
Conversation
Add an explicit, optional React peerDependency for partysocket so strict package managers (e.g. pnpm) correctly resolve react for the partysocket/react and partysocket/use-ws subpath exports. This includes a new changeset and package.json updates. Also: tighten test typings (import and use WsWebSocket instead of any), rename an unused handler param to _lobby to avoid linter noise, and add explanatory comments plus a biome-ignore on the memoized socket options to avoid unnecessary reconnects when callers pass inline option objects.
🦋 Changeset detectedLatest commit: 86b5022 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hono-party
partyfn
partyserver
partysocket
partysub
partysync
partytracks
partywhen
y-partyserver
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #292
reactas an optional peer dependency (>=17) inpartysocket, so strict package managers like pnpm correctly resolve it for thepartysocket/reactandpartysocket/use-wssubpath exports. Marked optional so users who only use the core WebSocket client aren't required to install React.anywith properWsWebSockettype in tests, prefixes unused param with_, and adds abiome-ignorefor the intentionaluseMemodependency pattern inuse-socket.ts.Test plan
npm run checkpasses (sherif, prettier, biome, typecheck, all test suites)partysocket/reactresolves React correctlyMade with Cursor