Skip to content

fix(scalesets): remove debug print leaking auth token to stdout#766

Merged
gabriel-samfira merged 1 commit into
cloudbase:mainfrom
cbartz:fix/scaleset-list-token-log-leak
Jun 5, 2026
Merged

fix(scalesets): remove debug print leaking auth token to stdout#766
gabriel-samfira merged 1 commit into
cloudbase:mainfrom
cbartz:fix/scaleset-list-token-log-leak

Conversation

@cbartz

@cbartz cbartz commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

What

ListRunnerScaleSets dumped its outgoing HTTP request to stdout, leaking the Actions service bearer token. Removes the leftover debug block (and the now-unused httputil import).

What it printed:

GET /_apis/runtime/runnerscalesets?api-version=6.0-preview HTTP/1.1
Host: <actions-service-host>
Authorization: Bearer <redacted>
Content-Type: application/json

Why

It's leftover debug instrumentation that writes a credential to stdout via fmt.Println rather than the structured logger, and it's ungated. The method itself is left in place in case it's reused.

ListRunnerScaleSets dumped the raw outgoing HTTP request via
httputil.DumpRequest + fmt.Println, which wrote the
"Authorization: Bearer <token>" header to stdout. Remove the debug
block and the now-unused net/http/httputil import.

@gabriel-samfira gabriel-samfira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabriel-samfira gabriel-samfira merged commit cb28ba6 into cloudbase:main Jun 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants