Add SolidJs integration#4495
Conversation
|
|
Razboy20
left a comment
Razboy20
left a comment
There was a problem hiding this comment.
Hi! Note I am not a contributor to SpacetimeDB, just happy for this PR. :)
As a SolidJS enjoyer myself, couple reactivity thoughts:
Use resources and stores instead of pure signals everywhere, and give useTable fine-grained reactivity.
solid-primitives db-store code example for integrating stores, useful read
Or create a resource with deep signals? Not sure
| const [rows, setRows] = createSignal< | ||
| readonly Prettify<UseTableRowType>[] | ||
| >([]); |
There was a problem hiding this comment.
This should probably be a store, updated with reconcile.
|
|
||
| const connectionState: ConnectionState = useSpacetimeDB(); | ||
|
|
||
| const [rows, setRows] = createSignal< |
There was a problem hiding this comment.
It doesn't look like setRows is called anywhere except in full snapshot updates
DanielBaumert
force-pushed
the
feature/solidjs-integration
branch
from
959f5bb to
8234731
Compare
|
A big thank you @Razboy20, Do you see any other problems? |
|
Hey @DanielBaumert, thank you for opening a PR for this! We'll work on getting it triaged and getting a reviewer for it. |
4 participants
Description of Changes
Add support for SolidJs
API and ABI breaking changes
None
Expected complexity level and risk
Complexity level: 1
Risk level: 1
Testing