add Deserialize::validate for non-allocating validation#4493
Open
add Deserialize::validate for non-allocating validation#4493
Deserialize::validate for non-allocating validation#4493Conversation
Centril
force-pushed
the
centril/sats-de-validate
branch
from
0e93ffc to
ccf8be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds
Deserialize::validateand all the friends necessary to make that work.The point of this is to enable allocation-less validation of input in some data format, in particular BSATN, against some expected type, in particular an
AlgebraicValueat anAlgebraicType.This is extracted from #4311 and is used there to convert raw BSATN to
BytesKeywithout constructing the compositeAlgebraicValuejust for validation only to throw it away immediately.API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
TODO: tweak existing SATS roundtrip tests to also check validation.