Skip to content

optimize decode path for versioned codec pending Phase 3 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikwuoz wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −10
Open

optimize decode path for versioned codec pending Phase 3 #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b05bd6
optimize decode path for versioned codec pending Phase 3
ikwuoz Jun 10, 2026
c0adaff
fix cargo fmt
ikwuoz Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions crates/types/src/codec/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ macro_rules! impl_versioned_codec {
return Err($crate::codec::error::CodecError::EmptyBytes);
}

if bytes[0] == $version_val as u8 {
let _ = bytes.get_u8();
return malachitebft_codec::Codec::decode(
&$crate::codec::proto::ProtobufCodec,
bytes,
)
.map_err($crate::codec::error::CodecError::Protobuf);
}

// TODO: Phase 3: Remove after all nodes are upgraded to use versioning
if let Ok(msg) = malachitebft_codec::Codec::decode(
&$crate::codec::proto::ProtobufCodec,
Expand All @@ -47,16 +56,9 @@ macro_rules! impl_versioned_codec {
}

let version_byte = bytes.get_u8();
let version = <$version_ty>::try_from(version_byte)
.map_err($crate::codec::error::CodecError::UnsupportedVersion)?;
if version != $version_val {
return Err($crate::codec::error::CodecError::UnsupportedVersion(
version_byte,
));
}

malachitebft_codec::Codec::decode(&$crate::codec::proto::ProtobufCodec, bytes)
.map_err($crate::codec::error::CodecError::Protobuf)
Err($crate::codec::error::CodecError::UnsupportedVersion(
version_byte,
))
}

fn encode(&self, msg: &$ty) -> Result<bytes::Bytes, Self::Error> {
Expand Down
Loading