Skip to content

Add attempted merge and hotfix metrics#312

Open
tijmendj wants to merge 2 commits intomasterfrom
add-merge-attempt-metrics
Open

Add attempted merge and hotfix metrics#312
tijmendj wants to merge 2 commits intomasterfrom
add-merge-attempt-metrics

Conversation

@tijmendj
Copy link
Copy Markdown

Used for finding change failure rates. Can also be used to find if merges failed.

@tijmendj tijmendj requested a review from Riscky April 20, 2026 13:26
Copy link
Copy Markdown

@Riscky Riscky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never explicitly register failures, just (successful) attempts. Do we also want to register failures?

Also I'd recommend registering the priority as a label, so you'd get:

hoff_project_merge_attempted_pull_requests{priority="high"}
hoff_project_merge_attempted_pull_requests{priority="normal"}

instead of two separate metrics

@tijmendj
Copy link
Copy Markdown
Author

We never explicitly register failures, just (successful) attempts. Do we also want to register failures?

I assumed that your failures can be derived from subtracting the successful attempts from your total attempts. If that's unwise we could look into tracking failures separately instead

@Riscky
Copy link
Copy Markdown

Riscky commented Apr 24, 2026

I assumed that your failures can be derived from subtracting the successful attempts from your total attempts. If that's unwise we could look into tracking failures separately instead

Not really, while the attempt it ongoing it will be added to one of the two metrics, but not the other (because we don't know if it will succeed yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants