Add CI to run fcx-web tests#2
Open
dokson wants to merge 1 commit into
Open
Conversation
Adds a matrix CI (format + warnings-as-errors + tests). To boot the suite, the fcxd driver is now opt-out via :start_driver (off in test), the ErrorView test no longer uses the removed Phoenix.View API, and fcx-web is formatted.
dokson
force-pushed
the
feature/ci-elixir-tests
branch
from
2c8fc58 to
f18819a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GitHub Actions CI for fcx-web. Runs the tests on every push and PR, across Elixir 1.15→1.19 / OTP 25→28. Also checks formatting and compiles with --warnings-as-errors.
Needed a few fixes to get the suite green:
mix testcrashed on app boot. Gated it behind:start_driver, off in test.Phoenix.View(gone since Phoenix 1.7). Now it teststemplate_not_found/2directly.elixirto~> 1.15. The old~> 1.14was wrong:ecto_sqlite3needs~> 1.15.config :logger, level: :warn→:warning(deprecated).mix formaton fcx-web.Format check runs once (lint job), tests run across the version matrix. Test DB is SQLite, so no DB service needed.
You know I love to format your code 😉