digitization: proposal for refactor file_import#29
Merged
namollayo merged 7 commits intocern-sis:mainfrom Apr 22, 2026
Merged
Conversation
* Implement fetch_boite_files to replace manual fetching * ref cern-sis#15
* Match Boite .xlsx records to S3 paths case-insensitively * Support flat and subfolder layouts for PDF and PDF_LATEX * Log unmatched files and output data for XML generation * ref cern-sis#24
namollayo
force-pushed
the
#24-file-matching-logic
branch
from
24cc87a to
8bd8602
Compare
PascalEgn
requested changes
Apr 15, 2026
Collaborator
PascalEgn
left a comment
PascalEgn
left a comment
There was a problem hiding this comment.
I check most of the code and left some comments, also i noticed that the matching of normal PDFs doesnt seem to work for me (but for PDF_Latex it does work). I suspect its because for PDF_Latex the pdf files on S3 are stored directly under the filename (for example PDF_LATEX/BOITE_O0126/300-BT-HK-D-1_latex.pdf) but for the 'normal' PDF its for example PDF/BOITE_O0126/300-BT-HK-D-1/300-BT-HK-D-1.pdf)
* Add support for optional expiration parameters in S3 URLs * Refactor code based on GitHub review feedback * ref cern-sis#24, cern-sis#15, cern-sis#25
…folders in CernboxProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Boite-to-S3 file matcher