digitization: proposal for refactor PDF check script#28
Merged
PascalEgn merged 5 commits intocern-sis:mainfrom Apr 15, 2026
Merged
digitization: proposal for refactor PDF check script#28PascalEgn merged 5 commits intocern-sis:mainfrom
PascalEgn merged 5 commits intocern-sis:mainfrom
Conversation
PascalEgn
requested changes
Mar 30, 2026
Collaborator
PascalEgn
left a comment
PascalEgn
left a comment
There was a problem hiding this comment.
Lets also add the functionallity to read a direcotry from CERNBox in order to check the Boite File numbers and then match them with the ones on S3, so we only check for the pdfs of the matched ones on S3
namollayo
force-pushed
the
22-check-pdf-script
branch
from
e01efd3 to
80d7da2
Compare
PascalEgn
requested changes
Apr 1, 2026
Collaborator
PascalEgn
left a comment
PascalEgn
left a comment
There was a problem hiding this comment.
Just some small things, otherwise looks really nice!
PascalEgn
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #22