fix: add recursion guard to traceSymbol to prevent StackOverflow on mutual assignment cycles#401
Open
Ayush-Patel-56 wants to merge 3 commits intocbomkit:mainfrom
Open
Conversation
Signed-off-by: Ayush Patel <ayushpatel2731@gmail.com>
Signed-off-by: Ayush Patel <ayushpatel2731@gmail.com>
… on mutual assignment cycles Signed-off-by: Ayush Patel <ayushpatel2731@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #400
visited: Set<Symbol>overload totraceSymbolin bothPythonDetectionEngineandJavaDetectionEnginenew HashSet<>(), so all call sites are unchangedTest plan
Issue400RecursionGuardTest(Python) — verifies a mutual assignment cycle (alg = intermediary; intermediary = alg) completes within 10 s withoutStackOverflowErrorand still detectsAESIssue8IntermediaryVariableTest(Python) — regression: single-hop indirection still resolves correctlyIssue8IntermediaryVariableTest(Java) — regression: intermediary variable chain still resolves correctlyIssue8MethodReceiverTest(Java) — regression: method-receiver intermediary still resolves correctly