feat: update REVERT_ROOT_HASH_ADDRESS#261
Open
stephenctw wants to merge 1 commit intofeature/bump-emulator-2-stephenfrom
Open
feat: update REVERT_ROOT_HASH_ADDRESS#261stephenctw wants to merge 1 commit intofeature/bump-emulator-2-stephenfrom
REVERT_ROOT_HASH_ADDRESS#261stephenctw wants to merge 1 commit intofeature/bump-emulator-2-stephenfrom
Conversation
stephenctw
changed the base branch from
main
to
feature/bump-emulator-2-stephen
stephenctw
force-pushed
the
feature/update-checkpoint-address
branch
from
9bd2f2a to
14cc4a8
Compare
edubart
requested changes
Apr 10, 2026
| - LOG2_STRIDE); | ||
|
|
||
| pub const CHECKPOINT_ADDRESS: u64 = 0x7ffff000; | ||
| pub const CHECKPOINT_ADDRESS: u64 = 0xfe0; |
There was a problem hiding this comment.
Instead of having this hardcoded, you could use CM_AR_SHADOW_REVERT_ROOT_HASH_START from the C API starting with emulator v0.20.0. Also we are calling this REVERT_ROOT_HASH on the emulator.
stephenctw
changed the title
CHECKPOINT_ADDRESSREVERT_ROOT_HASH_ADDRESS
stephenctw
force-pushed
the
feature/update-checkpoint-address
branch
from
14cc4a8 to
ec077a2
Compare
stephenctw
force-pushed
the
feature/update-checkpoint-address
branch
2 times, most recently
from
8a03100 to
e88d495
Compare
stephenctw
force-pushed
the
feature/update-checkpoint-address
branch
from
e88d495 to
3e07926
Compare
|
This is probably blocked by the PR bumping the emulator #241 |
|
I updated the emulator bump PR ref. #241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving checkpoint address change mentioned here.