Skip to content

Custom errors and Rollups contracts bump#260

Merged
guidanoli merged 9 commits intonext/3.0from
feature/custom-errors
Apr 8, 2026
Merged

Custom errors and Rollups contracts bump#260
guidanoli merged 9 commits intonext/3.0from
feature/custom-errors

Conversation

@guidanoli
Copy link
Copy Markdown
Collaborator

@guidanoli guidanoli commented Apr 6, 2026

This PR makes several changes:

  • Adds documentation to all existing custom errors in ITournament
  • Renames the parameters of some errors in ITournament
  • De-duplicates some errors in ITournament
  • Converts error strings into custom errors (defined in ITournament)
  • Calls canBeEliminate internally (and not through this.)
  • Bumps Rollups contracts from 2.2.0 to 3.0.0-alpha.3

This last change is quite dense, so I'll break it down even further:

  • Skip deployment of test tokens (as they are now present in Rollups SDK devnet)
  • Remove local source code of test tokens
  • Remove CannonDeployments.sol (as ApplicationFactory is now part of the build)
  • Add WithdrawalConfig param to Dave app deployment entrypoints
  • Make DaveConsensus implement getLastFinalizedMachineMerkleRoot
  • Make DaveConsensus.settle revert if app is foreclosed
  • Use Keccak256, Math, and Merkle libraries from Rollups SDK
  • Remove local source code and tests of Merkle and Math libraries
  • Make IDaveConsensus inherit from BinaryMerkleTreeErrors (defines errors that may be raised by LibBinaryMerkleTree from the Rollups SDK contracts)
  • Improves the tests of DaveAppFactory (more similar to Rollups SDK contract tests)
  • Adjusts Rust and Lua test codes (because of new deployment signatures, and inputs being added after deployment)

Closes #257

@guidanoli guidanoli added this to the 3.0.0 milestone Apr 6, 2026
@guidanoli guidanoli self-assigned this Apr 6, 2026
@guidanoli guidanoli moved this from Todo to Waiting review in Rollups SDK Apr 6, 2026
@guidanoli guidanoli linked an issue Apr 6, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@stephenctw stephenctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@github-project-automation github-project-automation Bot moved this from Waiting review to Waiting Merge in Rollups SDK Apr 7, 2026
@guidanoli guidanoli moved this from Waiting Merge to Waiting review in Rollups SDK Apr 7, 2026
Copy link
Copy Markdown
Collaborator

@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I found a minor typo.

Comment thread prt/contracts/src/ITournament.sol Outdated
@github-project-automation github-project-automation Bot moved this from Waiting review to Waiting Merge in Rollups SDK Apr 7, 2026
@guidanoli guidanoli force-pushed the feature/custom-errors branch from b4b0ff7 to e0fd07d Compare April 8, 2026 14:55
@guidanoli guidanoli merged commit 9f6a3c5 into next/3.0 Apr 8, 2026
7 checks passed
@guidanoli guidanoli deleted the feature/custom-errors branch April 8, 2026 15:38
@github-project-automation github-project-automation Bot moved this from Waiting Merge to Done in Rollups SDK Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Convert error strings to custom errors

3 participants