Custom errors and Rollups contracts bump#260
Merged
Conversation
GCdePaula
approved these changes
Apr 7, 2026
Collaborator
GCdePaula
left a comment
There was a problem hiding this comment.
LGTM! I found a minor typo.
b4b0ff7 to
e0fd07d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several changes:
ITournamentITournamentITournamentITournament)canBeEliminateinternally (and not throughthis.)This last change is quite dense, so I'll break it down even further:
CannonDeployments.sol(asApplicationFactoryis now part of the build)WithdrawalConfigparam to Dave app deployment entrypointsDaveConsensusimplementgetLastFinalizedMachineMerkleRootDaveConsensus.settlerevert if app is foreclosedIDaveConsensusinherit fromBinaryMerkleTreeErrors(defines errors that may be raised byLibBinaryMerkleTreefrom the Rollups SDK contracts)DaveAppFactory(more similar to Rollups SDK contract tests)Closes #257