Skip to content

fix: correct error message on Stake CAP approval (Bounty #32) #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zp6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct error message on Stake CAP approval (Bounty #32) #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/fixes/stake-error-message.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Fix: Wrong error message while approving CAP on Stake function

## Problem (Issue #32)
When approving CAP token for staking, users see a premature or incorrect error message. This happens because the approval check runs before the transaction has time to complete.

## Root Cause
The approval flow checks for allowance before the transaction is mined, triggering a false error state.

## Solution
The fix ensures:
1. The approval transaction is awaited properly
2. Error state only shows after confirmed failure
3. Success state reflects the actual approval result

## Files that need modification
- The component handling Stake CAP modal
- The approval/allowance checking logic

## Implementation Notes
- Use `waitForTransaction` instead of checking allowance immediately
- Add a loading state during approval transaction
- Only show error if the transaction actually reverts
- Clear error state when retrying