Show current and new liquidation price in edit margin modal#161
Open
rebel117 wants to merge 1 commit into
Open
Show current and new liquidation price in edit margin modal#161rebel117 wants to merge 1 commit into
rebel117 wants to merge 1 commit into
Conversation
Display the current liquidation price alongside the new calculated price when adding or removing margin, so users can see the impact of their margin adjustment at a glance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When adding or removing margin, users could only see the new liquidation price but not the current one, making it hard to understand the impact of the margin change.
Solution
Added a "Current Liq. Price" row above the existing "New Liq. Price" row in the EditMargin modal, so both values are visible side by side for comparison.
Changes
src/components/modals/EditMargin.svelte: AddedcurrentLiqPricevariable initialized fromdata.position.liqpriceand a new LabelValue row displaying itTesting
formatForDisplayformatter for consistent formattingCloses #4