docs: document juju_unit label injection for wildcard and non-wildcard scrape targets#246
Open
Abuelodelanada wants to merge 8 commits intotrack/2from
Open
docs: document juju_unit label injection for wildcard and non-wildcard scrape targets#246Abuelodelanada wants to merge 8 commits intotrack/2from
Abuelodelanada wants to merge 8 commits intotrack/2from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation to explain how the prometheus_scrape library injects the juju_unit topology label into Prometheus scrape jobs for both wildcard and non-wildcard scrape targets, helping users understand when per-unit labeling is (and isn’t) applied.
Changes:
- Document
juju_unitlabel injection behavior for wildcard vs non-wildcard scrape targets undermetrics-endpoint. - Extend the “exposing a metrics endpoint” how-to with guidance and an example for explicit (non-wildcard) targets.
- Clean up minor Markdown formatting/indentation in the topology labels reference doc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/reference/juju-topology-labels.md | Adds a new “metrics-endpoint” subsection describing juju_unit injection behavior for wildcard and non-wildcard scrape targets. |
| docs/how-to/exposing-a-metrics-endpoint.md | Adds guidance and a code example for using explicit non-wildcard targets and explains juju_unit enrichment behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jose Massón <939888+Abuelodelanada@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jose Massón <939888+Abuelodelanada@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Document how the prometheus_scrape library injects the juju_unit topology label into Prometheus scrape jobs, covering both wildcard and non-wildcard targets.
Checklist