Conversation
There was a problem hiding this comment.
👍
this should also fix #250 since the fix for the problem there has been backported to go1.25.4 golang/go#75775
btw, because of this issue i've been using chisel compiled with go1.26 and i've seen no regressions due to golang version bump
Correct!
Nice to know the path to a future bump to |
letFunny
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for working on it. I think we should create a backlog item to come back and fix the lints in the (near) future.
| - unused | ||
|
|
||
| exclusions: | ||
| generated: lax |
There was a problem hiding this comment.
Should we also have a TODO here to move to strict and follow the standard on generated code?
Bump the minimal go version to
1.25.8, fixing the following vulnerabilities, affecting go1.24.6:CVE-2025-68121 (CRITICAL)
CVE-2025-58183 (HIGH)
CVE-2025-61726 (HIGH)
CVE-2025-61728 (HIGH)
CVE-2025-61729 (HIGH)
go
1.24.13cannot be used as it is not available yet in the snapstore.go
1.26cannot be used either as there is no stable snap of it in the snapstore.govulncheckdoes not identify any vulnerabilities after this fix.trivydoes not identify anystdlib-related vulnerabilities after this fix.golangci-lintis also bumped tov2.xto be compatible with go1.25. To do so, the configuration is migrated to thev2format, with the minimum amount of changes. Some checks are excluded to avoid unrelated fixes in this PR. They should be re-enabled in a follow-up PR and the code corrected.