Allow attaching multiple components to an incident with the API#293
Open
itsnewtjam wants to merge 4 commits intocachethq:mainfrom
Open
Allow attaching multiple components to an incident with the API#293itsnewtjam wants to merge 4 commits intocachethq:mainfrom
itsnewtjam wants to merge 4 commits intocachethq:mainfrom
Conversation
jbrooksuk
requested changes
Aug 30, 2025
Member
jbrooksuk
left a comment
There was a problem hiding this comment.
This is great work, thanks @itsnewtjam. Could you please add a test case for this and then we can get it merged.
Author
|
@jbrooksuk Test added! Not sure why the CreateMetricPoint test failed in the checks though, seems unrelated and it's passing fine locally |
|
Hey there, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #156
Supports attaching multiple components when creating an incident via API:
Also:
componenttemplate variable, just in case :)incident_componentstable when an incident is deleted