incident doesn't update with update status (#219)#256
Draft
icecoldPHP wants to merge 3 commits intocachethq:mainfrom
Draft
incident doesn't update with update status (#219)#256icecoldPHP wants to merge 3 commits intocachethq:mainfrom
icecoldPHP wants to merge 3 commits intocachethq:mainfrom
Conversation
icecoldPHP
changed the title
icecoldPHP
changed the title
Contributor
|
It might be cleaner to use an Event and Listener to handle updates to the parent Incident status. You can also added support for triggering a webhook whenever the incident status changes. You can check out my example here: @jbrooksuk I'd love to hear your thoughts on this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you add an update to an incident it doesn't update the incident's status.
This fixes that
#219